Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hideOn="clickout" hides after clicking on nested attachments. #90

Open
kybishop opened this issue Nov 27, 2017 · 2 comments
Open

hideOn="clickout" hides after clicking on nested attachments. #90

kybishop opened this issue Nov 27, 2017 · 2 comments

Comments

@kybishop
Copy link
Collaborator

The clickout listener evaluates whether or not the click event's target is contained within the attachment's target, or the attachment itself when interactive=true.

This is borked when there is an attachment within the attachment, since that attachment will have been moved to the body.

Need to find a clever way to determine if a nested attachment is actually a child of another attachment.

@kybishop kybishop changed the title hideOn="clickout" hides when click on nested attachments. hideOn="clickout" hides after clicking on nested attachments. Nov 27, 2017
@kybishop kybishop added this to the v1.0.0 milestone Dec 2, 2017
@kybishop
Copy link
Collaborator Author

kybishop commented Dec 2, 2017

I'm marking this v1.0.0 for now, but there's a good chance we'll punt until later. At the very least, I'll spend a solid day or two looking into this before spiking or punting.

@kybishop
Copy link
Collaborator Author

kybishop commented Dec 2, 2017

A current work around for this is to use renderInPlace on the nested attachments. This works great regarding z-index issues since the top level parent attachment is already on the body.

@kybishop kybishop removed this from the v1.0.0 milestone Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant