Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@ember/test-waiters should be a non-dev dependency or peerDependency #992

Open
gorner opened this issue Dec 9, 2024 · 1 comment · May be fixed by #993
Open

@ember/test-waiters should be a non-dev dependency or peerDependency #992

gorner opened this issue Dec 9, 2024 · 1 comment · May be fixed by #993

Comments

@gorner
Copy link

gorner commented Dec 9, 2024

Our app is currently setup to use ember-try to test against versions of Ember later than the one we're on. Over the weekend, a new version of @ember/test-waiters (restructured as a V2 addon) was released which (for reasons I won't get into right now) started to be included in our ember-try runs, and leads to the following error being raised while booting the app to run tests:

ember-attacher tried to import "@ember/test-waiters" in "ember-attacher/components/attach-popover.js" from addon code, but "@ember/test-waiters" is a devDependency. You may need to move it into dependencies.

I was able to work around this by constraining our app to use @ember/test-waiters v3.1.0, but it does look like ember-attacher is declaring test-waiters under devDependencies when, given that it's accessed in component code and not just in tests, it should be under dependencies or maybe peerDependencies.

Happy to submit a PR, just wanted to get this up quickly to ensure you (and any other users running into this) are aware.

@tylerturdenpants
Copy link
Owner

Please do!

@gorner gorner linked a pull request Dec 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants