Serializer.validators type does not include Unique... validators

[mschoettle]

Bug report

What's wrong

The Serializer.validatorsproperty has the type

Type of "self.validators" is "list[((Any) -> None) | ContextValidator[Any]]"

This is the result of reveal_type(self.validators) on an instance of ModelSerializer. I don't see it explicitly defined in serializers.pyi so I am not sure where exactly it is coming from.

When evaluating the elements of the list against UniqueTogetherValidator mypy reports that the condition always returns False.

None of the Unique... validators are a type that is mentioned above so that is my assumption why that is.

How is that should be

The type for the validators property should include the Unique... validators (at least for ModelSerializer).

System information

• OS:
• python version: 3.122
• django version: 4.2.11
• mypy version: 1.8.0
• django-stubs version: 4.2.7

[Napparific]

I have encountered the same issue!

[Limsunoh]

@mschoettle I'm a junior developer, can I take a look at this?

[mschoettle]

@Limsunoh Yes, of course

[Limsunoh]

@mschoettle I've made code fixes and test code, can I put them together in a PR? But I'm not sure if this is correct

[Limsunoh]

@mschoettle I also created a separate test code file this way, do I need to upload the test code as well? Or should I upload it without the test files?

[Napparific]

@Limsunoh Most open source repositories (this one included) will have a contribution guide you can use to understand what the requirements in a PR are