Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for Console.readLine #1263

Closed
djspiewak opened this issue Oct 4, 2020 · 0 comments
Closed

Add unit tests for Console.readLine #1263

djspiewak opened this issue Oct 4, 2020 · 0 comments
Assignees
Milestone

Comments

@djspiewak
Copy link
Member

Follow up to #1261. readLine is currently untested, and it's a relatively complex bit of functionality. We should add some unit tests based on canned pre-encoded files in various character sets. We should also ensure that both Windows and Unix line endings work.

At present, the above have been manually tested, but getting it automated should be considered a priority.

@djspiewak djspiewak added the CE 3 label Oct 4, 2020
@RaasAhsan RaasAhsan added this to the 3.0.0-M2 milestone Oct 5, 2020
@vasilmkd vasilmkd self-assigned this Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants