Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WriterT Monoid #1012

Closed
yilinwei opened this issue May 3, 2016 · 2 comments
Closed

Add WriterT Monoid #1012

yilinwei opened this issue May 3, 2016 · 2 comments

Comments

@yilinwei
Copy link
Contributor

yilinwei commented May 3, 2016

I would like to add an implicit Monoid for WriterT. I've copied the implementation from scalaz here.

I would like to add some tests for the commit but am having a little trouble understanding how the tests work and should be structured. My initial attempt is here where I've just made sure that the Monoid and Semigroup can be resolved.

@adelbertc
Copy link
Contributor

You'll also have to test the Monoid laws for it

@yilinwei
Copy link
Contributor Author

yilinwei commented May 3, 2016

I had some issues finding them at first (which was what I meant to ask) because I didn't realise they were under GroupLaws in kernel.

I've now added the test here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants