Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Scala.js Future tests #3247

Closed
travisbrown opened this issue Jan 9, 2020 · 1 comment
Closed

Fix Scala.js Future tests #3247

travisbrown opened this issue Jan 9, 2020 · 1 comment

Comments

@travisbrown
Copy link
Contributor

Right now the Scala.js FutureTests use the runNow execution context, which was deprecated in Scala.js 0.6 and removed in 1.0. In #3246 I replace runNow with an equivalent implementation, since I want to unblock 1.0 compatibility, but this isn't a real solution (see e.g. this issue for discussion).
@travisbrown travisbrown mentioned this issue Jan 9, 2020
Merged
@larsrh
Copy link
Contributor

larsrh commented Jan 30, 2021

Seems like this is not an issue any more.

@larsrh larsrh closed this as completed Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@travisbrown @larsrh