-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stream.fromQueue* could take a QueueSource instead of a Queue #2437
Comments
Agreed. I don't know if this will be a binary compatible change, though - if not, we can probably work around by making the existing functions package-private and adding new ones. |
Should be binary compatible since it's a contravariant parameter adjustment. |
I thought this too! But, MiMa didn't agree, I'd be really really interested to hear an explanation for why. |
@djspiewak These are static methods, not class methods. |
|
I believe the signatures for
Stream.fromQueueUnterminated
, etc., could be narrowed to takeQueueSource
instead ofQueue
, because they only rely on thetake
andtryTake
methods. Then if users want to translate aQueue
to aStream
they don't have to require knowledge of the "write" methods of theQueue
, only the "read" methods.The text was updated successfully, but these errors were encountered: