Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Attributes builder #371

Closed
iRevive opened this issue Nov 14, 2023 · 0 comments · Fixed by #382
Closed

Add Attributes builder #371

iRevive opened this issue Nov 14, 2023 · 0 comments · Fixed by #382

Comments

@iRevive
Copy link
Contributor

iRevive commented Nov 14, 2023 

          I feel like there's a lot of inefficient conversions here: `toList`, `.result()`, `: _*` ...

It can be a follow-up, but I wonder if we can either have a mutable AttributesBuilder that is backed by a MapBuilder or we could have Attributes.unsafeFromMap style builder.

Originally posted by @armanbilge in #369 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Builder of Attributes. Documentation improvements iRevive/otel4s
1 participant
@iRevive