Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ES6 Map and Set for regular validators with each option #430

Merged
merged 1 commit into from
Oct 14, 2019
Merged

feat: support ES6 Map and Set for regular validators with each option #430

merged 1 commit into from
Oct 14, 2019

Conversation

vlapo
Copy link
Contributor

@vlapo vlapo commented Oct 2, 2019

Looks like we do not support each option for Map and Set (#428)

This PR add support Map/Set for regular validators and custom validators @Validate.

Also small unit tests added.

Close #428

@vlapo
Copy link
Contributor Author

vlapo commented Oct 2, 2019

@henrikra and @rubiin as active contributors please review. All reviews are welcome.

@rubiin
Copy link
Contributor

rubiin commented Oct 3, 2019

Had a look at the code, doesn't seem to have any bugs so far @vlapo

@vlapo vlapo merged commit a055bba into typestack:master Oct 14, 2019
@vlapo vlapo deleted the better-support-map-set branch October 14, 2019 09:43
@github-actions
Copy link

github-actions bot commented Aug 4, 2020

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Map validation like in the examples doesn't seem to work
2 participants