Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove chrono dependency #3874

Closed
wants to merge 1 commit into from
Closed

Conversation

frozolotl
Copy link
Contributor

@frozolotl frozolotl commented Apr 4, 2024

With this PR, typst-cli uses time, same as typst.
This should reduce compile times by a bit.

`typst-cli` now uses `time`, just like is done within `typst`.
This should reduce compile times by a bit.
@laurmaedje
Copy link
Member

This was attempted before, but then reverted because it caused issues.

The time crate fails on Unix when retrieving the local offset while there are multiple threads because it is unsound. Chrono, on the other hand, parses the timezone information itself instead of using system APIs, circumventing the problem. See also time issue.

@frozolotl
Copy link
Contributor Author

Interesting, I was under the assumption it was fixed already. It seems to have simply worked because my test document was compiled on one thread only.

@frozolotl frozolotl closed this Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants