Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows family contains major version #287

Open
theikkila opened this issue Nov 29, 2017 · 1 comment
Open

Windows family contains major version #287

theikkila opened this issue Nov 29, 2017 · 1 comment

Comments

@theikkila
Copy link
Contributor

theikkila commented Nov 29, 2017 •
edited
Loading

Windows UA:s have been recognized with major version as part of the family.

ie.

Mozilla/5.0 (Windows NT 10.0## Win64## x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.116 Safari/537.36 Edge/15.15063

{ "family": "Windows 10",
   "major": null,
   "minor": null,
   "patch": null,
   "patchMinor": null },

should be:

{ "family": "Windows",
   "major": "10",
   "minor": null,
   "patch": null,
   "patchMinor": null }

or even with minor defined too
@jimdigriz
Copy link
Contributor

jimdigriz commented Apr 6, 2018 •
edited
Loading

I suspect this is addressed by #110 and #286

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@theikkila @jimdigriz