Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to add TikTok #511

Open
mckingho opened this issue Nov 24, 2021 · 5 comments · May be fixed by #591
Open

Request to add TikTok #511

mckingho opened this issue Nov 24, 2021 · 5 comments · May be fixed by #591

Comments

@mckingho
Copy link

I suggest to add TikTok user agent regex to the social part.

@russellwhitaker
Copy link
Contributor

@mckingho do you have a candidate pull request with a pattern and test coverage?

@mckingho
Copy link
Author

@russellwhitaker Yes. I shall submit a PR once I update the tests.

@geohci
Copy link

geohci commented Dec 20, 2022

@mckingho I'd like to see this support added as well. any chance that this is close to incorporation or you can share where you were at with it?

@mckingho
Copy link
Author

@geohci
I do not identity TikTok clients in production at the moment. My findings ends with an example TikTok 16.0.16 rv:103005 (iPhone; iOS 11.1.4; en_EN) Cronet from user-agents.net. I suggest checking TikTok prefix followed by semantic versioning.
But I did not commit anything because I lack sufficient examples. You can take this feature request if you have more information.

@geohci
Copy link

geohci commented Jan 3, 2023

@mckingho yes sufficient examples was my concern too. As one example, I navigated to a website URL via TikTok and then checked the user-agent for the browser. For that phone, it gave (hand-copied so excuse any small typos):

Mozilla/5.0 (Linux; Android 10; moto g(7) Build/QP6_S30.52-23-13-4; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/108.0.5359.128 Mobile Safari/537.36 musical_ly_2022704050 JsSdk/1.0 NetType/WIFI Channel/googleplay AppName/musical_ly app_version/27.4.5 ByteLocale/en ByteFullLocale/en Region/US Spark/1.2.4-alpha.5 AppVersion/27.4.5 PIA/1.5.10 BytedanceWebview/d8a21c6

From that, I see a few identifying characteristics (BytedanceWebview and AppName/musical_ly probably) but am not sure what to extract from the rest and how stable it is.

@Sirozha1337 Sirozha1337 linked a pull request Jun 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@russellwhitaker @mckingho @geohci and others