Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Versions that aren't just major/minor/patch aren't parsed correctly #519

Open
dolfies opened this issue May 14, 2022 · 1 comment
Open

Versions that aren't just major/minor/patch aren't parsed correctly #519

dolfies opened this issue May 14, 2022 · 1 comment

Comments

@dolfies
Copy link

dolfies commented May 14, 2022 •
edited
Loading

For example, with the latest chrome user-agent (Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/101.0.4951.67 Safari/537.36), the .67 is lost.
@1kevgriff
Copy link

1kevgriff commented Oct 10, 2022 •
edited
Loading

We're seeing this too. Because of issues like #452, we're trying to rebuild the ClientInfo instance ourselves with UAFullVersion hints, but we can't because the UserAgent constructor only takes 3 parameters and not 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@1kevgriff @dolfies and others