From 24b79770f15487182d38aec5d3fcb34c7fb8fe66 Mon Sep 17 00:00:00 2001 From: rexywork <118593354+rexywork@users.noreply.github.com> Date: Sun, 7 May 2023 09:41:42 +0700 Subject: [PATCH] Add Name() to Logger (#1273) Adds the `Name()` function to `Logger`, which will return the logger's name, if configured. --- logger.go | 6 ++++++ logger_test.go | 6 ++++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/logger.go b/logger.go index cd44030d1..0e9548011 100644 --- a/logger.go +++ b/logger.go @@ -281,6 +281,12 @@ func (log *Logger) Core() zapcore.Core { return log.core } +// Name returns the Logger's underlying name, +// or an empty string if the logger is unnamed. +func (log *Logger) Name() string { + return log.name +} + func (log *Logger) clone() *Logger { copy := *log return © diff --git a/logger_test.go b/logger_test.go index cd5cd20c8..d4af57512 100644 --- a/logger_test.go +++ b/logger_test.go @@ -340,7 +340,8 @@ func TestLoggerNames(t *testing.T) { } log.Info("") require.Equal(t, 1, logs.Len(), "Expected only one log entry to be written.") - assert.Equal(t, tt.expected, logs.AllUntimed()[0].LoggerName, "Unexpected logger name.") + assert.Equal(t, tt.expected, logs.AllUntimed()[0].LoggerName, "Unexpected logger name from entry.") + assert.Equal(t, tt.expected, log.Name(), "Unexpected logger name.") }) withSugar(t, DebugLevel, nil, func(log *SugaredLogger, logs *observer.ObservedLogs) { for _, n := range tt.names { @@ -348,7 +349,8 @@ func TestLoggerNames(t *testing.T) { } log.Infow("") require.Equal(t, 1, logs.Len(), "Expected only one log entry to be written.") - assert.Equal(t, tt.expected, logs.AllUntimed()[0].LoggerName, "Unexpected logger name.") + assert.Equal(t, tt.expected, logs.AllUntimed()[0].LoggerName, "Unexpected logger name from entry.") + assert.Equal(t, tt.expected, log.base.Name(), "Unexpected logger name.") }) } }