Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing wildcard to subscribe(Observer) methods #244

Merged
merged 1 commit into from
Aug 9, 2018
Merged

Add missing wildcard to subscribe(Observer) methods #244

merged 1 commit into from
Aug 9, 2018

Conversation

ZacSweers
Copy link
Collaborator

Resolves #243

@ZacSweers ZacSweers self-assigned this Aug 9, 2018
@ZacSweers ZacSweers mentioned this pull request Aug 9, 2018
Closed
tadfisher
tadfisher approved these changes Aug 9, 2018
View reviewed changes
Copy link

@tadfisher tadfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ZacSweers ZacSweers merged commit 921965d into master Aug 9, 2018
@ZacSweers ZacSweers deleted the z/fixSubscribeCovariance branch August 9, 2018 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyvsmith tyvsmith tyvsmith approved these changes

@tadfisher tadfisher tadfisher approved these changes

@jbarr21 jbarr21 Awaiting requested review from jbarr21

Assignees

@ZacSweers ZacSweers

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZacSweers @tadfisher @tyvsmith