From c80cab63d81c35178e7b6e75ee5c11bb4b37a0d5 Mon Sep 17 00:00:00 2001 From: Roland Stevenson Date: Wed, 29 Nov 2023 17:19:33 +0100 Subject: [PATCH] revert learner_1/2 qini_score calc --- tests/test_metrics.py | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/tests/test_metrics.py b/tests/test_metrics.py index 0ca9feaf..7448c491 100644 --- a/tests/test_metrics.py +++ b/tests/test_metrics.py @@ -18,14 +18,10 @@ def test_qini_score(): full_result = qini_score(test_df) # get qini score for learner_1 separately - learner_1_result = qini_score( - test_df[["y", "w", "learner_1"]], treatment_effect_col="learner_1" - ) + learner_1_result = qini_score(test_df[["y", "w", "learner_1"]]) # get qini score for learner_2 separately - learner_2_result = qini_score( - test_df[["y", "w", "learner_2"]], treatment_effect_col="learner_2" - ) + learner_2_result = qini_score(test_df[["y", "w", "learner_2"]]) # for each learner, its qini score should stay same no matter calling with another model or calling separately assert isclose(full_result["learner_1"], learner_1_result["learner_1"])