This repository has been archived by the owner on May 23, 2024. It is now read-only.
Rename RPC metrics and use more tags #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In practice, the precision of the recorded timing values depends on the metrics backend and the client library. Since we're using time.Duration based API, we cannot claim the unit of measure in the metric name.
yurishkuro
changed the title
black-adder
reviewed
Mar 21, 2017
| } | ||
|
|
||
| func endpointTags(endpoint string, kv ...string) map[string]string { | ||
| return tags(append([]string{"endpoint", endpoint}, kv...)...) |
There was a problem hiding this comment.
does tags("endpoint", endpoint, kv...) not work?
black-adder
approved these changes
Mar 21, 2017
|
+1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove "_ms" suffix from request latency metric name
In practice, the precision of the recorded timing values
depends on the metrics backend and the client library.
Since we're using time.Duration based API, we cannot claim
the unit of measure in the metric name.
Rename all metrics to "request" and "http_request" and use tags for other dimensions
error=true|falsetag.status_code=2xx|3xx|...tag