Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listeners get clobbered #381

Closed
mcnuttandrew opened this issue Apr 13, 2017 · 8 comments
Closed

Listeners get clobbered #381

mcnuttandrew opened this issue Apr 13, 2017 · 8 comments

Comments

@mcnuttandrew
Copy link
Contributor

There is a reasonably frequent bug in which onValueMouseOut/onSeriesMouseOut listeners are not called due to the presence of other listeners. This often occurs in conjunction with the presence of animation. (To wit, check out the animated sunburst for more)

@sam-silv
Copy link
Contributor

This is what I was running into in my other PR - in my experience onMouseLeave is more reliable

@ajainarayanan
Copy link

@mcnuttandrew @samhogg Are there any updates on this issue? Is there a resolution that was reached that you can share. Let me know if I can be of any help. I'm facing this issue on all the MarkSeries graphs that I'm rendering and as a workaround I right now bind the esc key and have an additional x on the Hint to close the hint.

The onValueMouseOver gets triggered but onValueMouseOut is not getting triggered for me.

@ajainarayanan
Copy link

ajainarayanan commented Jul 11, 2017

For reference I have created this webpackbin if someone wants to try to reproduce the issue: https://www.webpackbin.com/bins/-Kok65xQnKmQZ5sp6xvL. The onmouseover triggers all the time but not the onmouseout event handler. Not sure if anything can be done on the react-vis layer. Probably an issue with chrome may be (facebook/react#4492)? 🤔

Sorry my bad. I have updated the webpack bin url with the right fix. On mouseover gets called until I move my mouse out and when mouse out even listener is triggered react seems to be batching the setStates and the resetting of hints is lost I believe. The current fix I have in there fixes showing/hiding the hints correctly.

@Harjot1Singh
Copy link

@ajainarayanan are you able to clarify what the fix is, that works with animation?

@vittvolt
Copy link

I'm also getting this problem on BarSeries, where onValueMouseOut / onSeriesMouseOut is not triggered.

@mcnuttandrew
Copy link
Contributor Author

Anyone following this issue might be interested in the discussion on #518

@Vednus
Copy link

Vednus commented Oct 13, 2017

I got this working by turning animation off when onValueMouseOver is called and then turning it back on when onValueMouseOut is called

@jckr
Copy link
Contributor

jckr commented Mar 9, 2018

I'm going to close this one and keep discussion on #518

@jckr jckr closed this as completed Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants