Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Switch to modified xone driver which supports upstream xpad #115

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

KyleGospo
Copy link
Member

@KyleGospo KyleGospo commented Jan 24, 2024

Far less problematic than our previous solution. Won't break controller support thanks to larger emphasis on xpad

Also fixes recent xone compilation issues as an added bonus
See: ublue-os/config#203

Additionally, drops zenpower3 thanks to zenergy rendering it obsolete.

chore: Drop unneeded zenpower3 driver thanks to zenergy
Copy link
Contributor

@bsherman bsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Using xone from Chimera which is "xone-xpad" instead of needing an "xpad-xone" plus "xone"...

Copy link
Member

@EyeCantCU EyeCantCU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Really happy to see this resolved :)

@KyleGospo KyleGospo added this pull request to the merge queue Jan 24, 2024
@KyleGospo KyleGospo removed this pull request from the merge queue due to a manual request Jan 24, 2024
@KyleGospo KyleGospo merged commit 9325c1c into main Jan 24, 2024
21 checks passed
@KyleGospo KyleGospo deleted the xonedo branch January 24, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants