-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: verify kmod signatures for dual-sign #218
Conversation
This checks during build stage and not in the final rpms. This doesn't ensure that the final copied rpms have the signatures. We could do that with another container much like getting the |
To build another container to test the rpms would likely have a longer build time than the actual akmods build. So not sure what the best method for ensuring the RPMs that are copied into the scratch container are indeed dual signed. |
Went and made a test container that is built after the akmods is built. It installs the kernel and the signed rpms, and then checks the signatures. It can handle both dual signed and single signed. It will stop a push if the the akmods are not signed correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful
Thank you for contributing to the Universal Blue project!
Please read the Contributor's Guide before submitting a pull request.