Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PXD-455 ⁃ isolate checking for validity of state/input #16

Open
rudyardrichter opened this issue Oct 24, 2017 · 0 comments
Open

PXD-455 ⁃ isolate checking for validity of state/input #16

rudyardrichter opened this issue Oct 24, 2017 · 0 comments

Comments

@rudyardrichter
Copy link
Contributor

rudyardrichter commented Oct 24, 2017

As is there is a lot of code interspersed throughout UploadTransaction and UploadEntity which checks to make sure that the input documents provided are correct and that the transaction is in a valid state (e.g. no nodes exist yet for entities to be created, or project id for nodes to be updated match the same project id for the transaction, etc.).

The code doing these checks should be separated from UploadTransaction and as self-contained as possible, to make more obvious/easier to find what is expected at any stage of the transaction.

@philloooo philloooo changed the title isolate checking for validity of state/input PXD-455 ⁃ isolate checking for validity of state/input May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant