Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dependencies ? #1144

Closed
3 tasks done
DorianXGH opened this issue Mar 21, 2022 · 3 comments
Closed
3 tasks done

Missing dependencies ? #1144

DorianXGH opened this issue Mar 21, 2022 · 3 comments
Labels

Comments

@DorianXGH
Copy link
Contributor

Background Work

Chipyard Version and Hash

Release: master
Hash: 51fea

OS Setup

Linux pompeius 5.16.13-arch1-1 #1 SMP PREEMPT Tue, 08 Mar 2022 20:07:36 +0000 x86_64 GNU/Linux
LSB Version: n/a
Distributor ID: Arch
Description: Arch Linux
Release: rolling
Codename: n/a

Other Setup

No response

Current Behavior

In sims/verilator/, make CONFIG=SmallBoomConfig
Doesn't compile, doesn't find apache commons dependencies : java.lang.NoClassDefFoundError: org/apache/commons/lang3/Validate
Adding

"org.apache.commons" % "commons-lang3" % "3.12.0",
"org.apache.commons" % "commons-text" % "1.9"

In the right dependency Seq, fixes the issue.

Expected Behavior

Compiles.

Other Information

I don't know whether or not the apache commons are supposed to be preinstalled and already in the CLASSPATH, but it doesn't seem so on arch.
I am posting the issue to ask whether or not to make a pull request with the aforementioned additions to the build.sbt.

@DorianXGH DorianXGH added the bug label Mar 21, 2022
@abejgonzalez
Copy link
Contributor

abejgonzalez commented Mar 22, 2022

I personally don't know of anyone that has tried using Arch for Chipyard tasks. Did you try installing similar things found in the -req.sh scripts here: https://github.com/ucb-bar/chipyard/blob/main/scripts/ubuntu-req.sh https://github.com/ucb-bar/chipyard/blob/main/scripts/centos-req.sh? (We assume that if you ran the following steps everything "should" work... but then again, Arch is trickier to setup).

@DorianXGH
Copy link
Contributor Author

Oh, like I said in the issue, it's not any package listed on these scripts. On Arch, it seems like the apache commons are in several separate packages. I think listing these as a dependency in the build system in build.sbt is appropriate, as they ARE a dependency, and it should be distribution independent, but then again I come from the Arch school of thought where every dependency should be listed as such x) (no implicit dependency)
The problem is fixed for me but I wanted to know if this was by design or if you would welcome a pull request adding the dependency to the build.sbt

@abejgonzalez
Copy link
Contributor

I would go ahead and add a PR for it. We can run it through our CI flow and see if anything breaks (but I think things will be fine). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants