-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Irrelevant Test Cases #2
Comments
* Use new FixedPoint instead of chisel's FixedPoint in all tests * Remove irrelevant test cases * Reformat files with scalafmt * Add scalafmt to CI
* Use new FixedPoint instead of chisel's FixedPoint in all tests * Remove irrelevant test cases * Reformat files with scalafmt * Add scalafmt to CI
Thanks for noticing, @fayalalebrun. Yes, these tests were indeed copied from Chisel; essentially every test file that referenced FixedPoint was copied as-is and then made to work inside the context of an external library. We've since cleaned up all the test cases that had nothing to do with FixedPoint. Some of the tests were even using Chisel's FixedPoint imports instead of this library's FixedPoint, so they weren't even testing this implementation... |
I noticed that many of the test cases included in this package don't reference FixedPoint. They seem to have been copied straight from the Chisel package. Is it a better approach to only include those tests which are relevant to the type, or is there a reason why the rest were included?
The text was updated successfully, but these errors were encountered: