Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off autocomplete in JavaScript's addAuthor form #300

Closed
Janell-Huyck opened this issue Nov 16, 2023 · 1 comment · Fixed by #382
Closed

Turn off autocomplete in JavaScript's addAuthor form #300

Janell-Huyck opened this issue Nov 16, 2023 · 1 comment · Fixed by #382
Assignees

Comments

@Janell-Huyck
Copy link
Contributor

In the addAuthor javascript function in app/assets/javascripts/ either in its own file or in application.js, we have a function addAuthor that includes manually creating lines inside a form. Those lines need to have autocomplete='off' on each line to prevent the form from being filled when the user uses the back-arrow. This is a security fix.

Example old code to modify:
<input type="text" name="${type}[author_last_name][]" id="${type}_author_last_name_" required="required" class="form-control form-group">

Must include test that checks for the autocomplete=off and when user uses back-arrow in browser, fields should not auto-complete with old information.

@Janell-Huyck
Copy link
Contributor Author

Waiting for merging of PR #309 before moving forward with this.

@Janell-Huyck Janell-Huyck added this to the Next deploy milestone Dec 7, 2023
@Janell-Huyck Janell-Huyck self-assigned this Dec 7, 2023
@hortongn hortongn removed this from the Next deploy milestone Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants