Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Failing Test after Hyrax Upgrade #1131

Open
2 of 5 tasks
scherztc opened this issue Dec 12, 2023 · 2 comments
Open
2 of 5 tasks

Fix Failing Test after Hyrax Upgrade #1131

scherztc opened this issue Dec 12, 2023 · 2 comments

Comments

@scherztc
Copy link
Contributor

scherztc commented Dec 12, 2023

Descriptive summary

Expected behavior

Actual behavior

Steps to reproduce the behavior

  1. Do this
  2. Then do this...

Related work

Link to related issues or prior related work here.

@scherztc scherztc added this to the Security and Maintenance milestone Dec 12, 2023
@Janell-Huyck
Copy link
Contributor

This error also shows upon trying to launch Scholar locally. I looked for and did not find a partial named "ga" or "_ga".

@Janell-Huyck
Copy link
Contributor

#1135 may not actually be an error - it is failing in an after-do block trying to clean up after a test. It tries to destroy a User that is not actually created due to an error inside the tests. It ties back into this error:

RSpec::Core::MultipleExceptionError: Error: "calc(100vh - 110px)" is not a number for `min'
        on line 1:30625 of stdin, in function `min`
        from line 1:30625 of stdin
>> x;flex:1;flex-direction:column;max-height:min(650px,calc(100vh - 110px));ove

This "calc" error seems to be triggered with images - it is caused by the logo and by the image_tag calls in a partial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants