Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HUT : _ga Google Analytics partial missing #1134

Closed
scherztc opened this issue Dec 13, 2023 · 2 comments · May be fixed by #1157
Closed

HUT : _ga Google Analytics partial missing #1134

scherztc opened this issue Dec 13, 2023 · 2 comments · May be fixed by #1157
Assignees
@crowesn @scherztc
Milestone
Security and Main...

Comments

@scherztc
Copy link
Contributor

Descriptive summary

Missing partial /_ga with {:locale=>[:en], :formats=>[:html], :variants=>[], :handlers=>[:raw, :erb, :html, :builder, :ruby, :coffee, :jbuilder]}

Expected behavior

When upgrading from hyrax 2.9.6 to 3.6, this test broke.

Actual behavior

Steps to reproduce the behavior

  1. Do this
  2. Then do this...

Related work

Link to related issues or prior related work here.
@scherztc scherztc added this to the Security and Maintenance milestone Dec 13, 2023
@crowesn crowesn self-assigned this Jan 2, 2024
@crowesn
Copy link
Contributor

crowesn commented Jan 3, 2024

This appears resolved on hyrax_3 branch.

  Rendered /Users/crowesn/.rbenv/versions/2.7.8/lib/ruby/gems/2.7.0/gems/hyrax-3.0.0/app/views/_ga.html.erb (0.1ms)

@scherztc scherztc self-assigned this Apr 16, 2024
@scherztc scherztc mentioned this issue Apr 16, 2024
Open
@scherztc
Copy link
Contributor Author

Closed by JIRA : https://ucdts.atlassian.net/browse/LIBSCHOLAR-3?atlOrigin=eyJpIjoiOWQwMzg4ZWI2MjFkNDAxZmJhZjhkODgyZTBhMWQzOTciLCJwIjoiaiJ9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crowesn crowesn

@scherztc scherztc

Labels
None yet
Projects
None yet
Milestone
Security and Maintenance
Development

Successfully merging a pull request may close this issue.

WIP : Hyrax fullcrum uclibs/ucrate
2 participants
@crowesn @scherztc