Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM builds on Windows unsupported with Version 2.5.0 #1422

Closed
Neumann-A opened this issue May 16, 2022 · 1 comment · Fixed by #1423
Closed

ARM builds on Windows unsupported with Version 2.5.0 #1422

Neumann-A opened this issue May 16, 2022 · 1 comment · Fixed by #1423

Comments

@Neumann-A
Copy link
Contributor

While arm builds on windows where fine with version 2.4.0 commit 1e6c925 broke them

Expected behavior and actual behavior.

a successful build on ARM

Steps to reproduce the problem.

Checkout microsoft/vcpkg#24734
run bootstrap.(sh|bat) to get vcpkg
vcpkg install openjpeg:arm64-windows

Operating system

windows

openjpeg version

2.5.0

Error:

FAILED: bin/openjp2.dll bin/openjp2.lib 
cmd.exe /C "cd . && D:\downloads\tools\cmake-3.22.2-windows\cmake-3.22.2-windows-i386\bin\cmake.exe -E vs_link_dll --intdir=src\lib\openjp2\CMakeFiles\openjp2.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\mt.exe --manifests  -- C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1431~1.311\bin\Hostx64\arm64\link.exe  src\lib\openjp2\CMakeFiles\openjp2.dir\thread.c.obj src\lib\openjp2\CMakeFiles\openjp2.dir\bio.c.obj src\lib\openjp2\CMakeFiles\openjp2.dir\cio.c.obj src\lib\openjp2\CMakeFiles\openjp2.dir\dwt.c.obj src\lib\openjp2\CMakeFiles\openjp2.dir\event.c.obj src\lib\openjp2\CMakeFiles\openjp2.dir\ht_dec.c.obj src\lib\openjp2\CMakeFiles\openjp2.dir\image.c.obj src\lib\openjp2\CMakeFiles\openjp2.dir\invert.c.obj src\lib\openjp2\CMakeFiles\openjp2.dir\j2k.c.obj src\lib\openjp2\CMakeFiles\openjp2.dir\jp2.c.obj src\lib\openjp2\CMakeFiles\openjp2.dir\mct.c.obj src\lib\openjp2\CMakeFiles\openjp2.dir\mqc.c.obj src\lib\openjp2\CMakeFiles\openjp2.dir\openjpeg.c.obj src\lib\openjp2\CMakeFiles\openjp2.dir\opj_clock.c.obj src\lib\openjp2\CMakeFiles\openjp2.dir\pi.c.obj src\lib\openjp2\CMakeFiles\openjp2.dir\t1.c.obj src\lib\openjp2\CMakeFiles\openjp2.dir\t2.c.obj src\lib\openjp2\CMakeFiles\openjp2.dir\tcd.c.obj src\lib\openjp2\CMakeFiles\openjp2.dir\tgt.c.obj src\lib\openjp2\CMakeFiles\openjp2.dir\function_list.c.obj src\lib\openjp2\CMakeFiles\openjp2.dir\opj_malloc.c.obj src\lib\openjp2\CMakeFiles\openjp2.dir\sparse_array.c.obj  /out:bin\openjp2.dll /implib:bin\openjp2.lib /pdb:bin\openjp2.pdb /dll /version:2.5 /machine:ARM64 /nologo    /debug /INCREMENTAL  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib  && cd ."
LINK Pass 1: command "C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1431~1.311\bin\Hostx64\arm64\link.exe src\lib\openjp2\CMakeFiles\openjp2.dir\thread.c.obj src\lib\openjp2\CMakeFiles\openjp2.dir\bio.c.obj src\lib\openjp2\CMakeFiles\openjp2.dir\cio.c.obj src\lib\openjp2\CMakeFiles\openjp2.dir\dwt.c.obj src\lib\openjp2\CMakeFiles\openjp2.dir\event.c.obj src\lib\openjp2\CMakeFiles\openjp2.dir\ht_dec.c.obj src\lib\openjp2\CMakeFiles\openjp2.dir\image.c.obj src\lib\openjp2\CMakeFiles\openjp2.dir\invert.c.obj src\lib\openjp2\CMakeFiles\openjp2.dir\j2k.c.obj src\lib\openjp2\CMakeFiles\openjp2.dir\jp2.c.obj src\lib\openjp2\CMakeFiles\openjp2.dir\mct.c.obj src\lib\openjp2\CMakeFiles\openjp2.dir\mqc.c.obj src\lib\openjp2\CMakeFiles\openjp2.dir\openjpeg.c.obj src\lib\openjp2\CMakeFiles\openjp2.dir\opj_clock.c.obj src\lib\openjp2\CMakeFiles\openjp2.dir\pi.c.obj src\lib\openjp2\CMakeFiles\openjp2.dir\t1.c.obj src\lib\openjp2\CMakeFiles\openjp2.dir\t2.c.obj src\lib\openjp2\CMakeFiles\openjp2.dir\tcd.c.obj src\lib\openjp2\CMakeFiles\openjp2.dir\tgt.c.obj src\lib\openjp2\CMakeFiles\openjp2.dir\function_list.c.obj src\lib\openjp2\CMakeFiles\openjp2.dir\opj_malloc.c.obj src\lib\openjp2\CMakeFiles\openjp2.dir\sparse_array.c.obj /out:bin\openjp2.dll /implib:bin\openjp2.lib /pdb:bin\openjp2.pdb /dll /version:2.5 /machine:ARM64 /nologo /debug /INCREMENTAL kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTFILE:src\lib\openjp2\CMakeFiles\openjp2.dir/intermediate.manifest src\lib\openjp2\CMakeFiles\openjp2.dir/manifest.res" failed (exit code 1120) with the following output:
   Creating library bin\openjp2.lib and object bin\openjp2.exp
ht_dec.c.obj : error LNK2019: unresolved external symbol __popcnt referenced in function population_count
bin\openjp2.dll : fatal error LNK1120: 1 unresolved externals

Reason: the Code switches on the compiler and ignores the architecture. Please only use intrinsics if the architecture is also met.

@Neumann-A
Copy link
Contributor Author

Patch here:
arm.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant