Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove all printf from openjpeg / use proper function pointer for logging #371

Closed
gcode-importer opened this issue Jul 5, 2014 · 5 comments

Comments

@gcode-importer
Copy link

Originally reported on Google Code with ID 371

The only decent log library for c seems to be zlog

http://hardysimpson.github.io/zlog/

But it is posix only. We would need to do a windows port.
In the meantime, we could probably use the same interface 
and just output to printf for windows.

Reported by boxerab on 2014-07-05 02:10:43

@gcode-importer
Copy link
Author

no external dep for such a low level implementation. opj mecanism allows one to use
any 3rd party log lib. closing as wontfix.

Reported by malaterre on 2014-09-17 09:58:32

  • Status changed: WontFix

@gcode-importer
Copy link
Author

I still see printf statements in the code. Does the opj mechanism redirect printf to
user-defined output? If not, I think we should convert all printf statements to use
the opj handler, in order to be consistent.

Reported by boxerab on 2014-09-17 14:27:27

@gcode-importer
Copy link
Author

agreed. I thought all printf(s) were removed in 1.x -> 2.x transition. Please report
here if you find one. thx.

Reported by malaterre on 2014-09-17 14:29:05

  • Status changed: Accepted

@gcode-importer
Copy link
Author

Most annoying are the fprintf's in t2.c (some of which still have a commented out opj_event_msg
call right beside them) and the three WARNING fprintf's in tcd.c and tgt.c which regulary
spam my console.

Reported by zeniko on 2014-10-30 19:43:59

@rouault
Copy link
Collaborator

rouault commented Sep 2, 2017

I can't see any (enabled) remaining printf/fprintf in t2.c, tcd.c and tgt.c. Closing

@rouault rouault closed this as completed Sep 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants