Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TriangulatePolygon has issues with some concave shapes #17

Open
Hemofektik opened this issue Mar 30, 2017 · 4 comments
Open

TriangulatePolygon has issues with some concave shapes #17

Hemofektik opened this issue Mar 30, 2017 · 4 comments

Comments

@Hemofektik
Copy link
Contributor

Hemofektik commented Mar 30, 2017

Some buildings are improperly triangulated.
See this s-shaped building in Berlin for example:
sberlin

In future support for polygons with holes (e.g. The Pentagon) would also be nice.

Thirdparty libraries like Poly2Tri could help here.

I would like to fix this myself but we should probably agree first on how to tackle this issue (ThirdParty lib yes/no, if yes how to integrate).

@MikeFricker
Copy link
Collaborator

I actually wrote a much better version recently for our new geometry editing feature in Unreal Engine recently. If you have linked your GitHub account with your Epic Games account, you can view the code right here. https://github.com/EpicGames/UnrealEngine/blob/dev-geometry/Engine/Source/Runtime/MeshEditingRuntime/EditableMesh.cpp#L1544 This is still in a development branch, but after it is released (in UE 4.17 most likely), we can switch StreetMap over to use the new algorithm.

@Hemofektik
Copy link
Contributor Author

Hemofektik commented Mar 30, 2017

That would also mean we could manipulate the generated buildings in the editor?!. Waiting for the UE4 release then sounds promising. Looking forward to it.

@MikeFricker
Copy link
Collaborator

We just finally merged my triangulation code into 4.20, so hopefully we can use the built in engine code to improve this in the near future.

@HeadClot
Copy link

@MikeFricker Does that mean that the new Geo Tools are going to be merged into 4.20?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants