Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peer dependency prosemirror-tables warning #555

Closed
jermitval opened this issue Dec 26, 2019 · 6 comments
Closed

peer dependency prosemirror-tables warning #555

jermitval opened this issue Dec 26, 2019 · 6 comments
Labels
Type: Bug The issue or pullrequest is related to a bug

Comments

@jermitval
Copy link

jermitval commented Dec 26, 2019

When installing with npm, throws the following warning:

npm WARN prosemirror-utils@0.9.6 requires a peer of prosemirror-tables@^0.9.1 
but none is installed. You must install peer dependencies yourself.

Do I need to install prosemirror-tables@^0.9.1 as waring?or just a bug?

@jermitval jermitval added the Type: Bug The issue or pullrequest is related to a bug label Dec 26, 2019
@jermitval jermitval reopened this Dec 26, 2019
@oshell
Copy link

oshell commented Jan 20, 2020

I have the same problem

@Peter-Krebs
Copy link

This happens for prosemirror-tables@1.0.0 as well. Example output (truncated)

├─┬ tiptap@1.26.6
└─┬ tiptap-extensions@1.28.6
  ├── UNMET PEER DEPENDENCY prosemirror-tables@1.0.0

npm WARN prosemirror-utils@0.9.6 requires a peer of prosemirror-tables@^0.9.1 but none was installed.

There is an open issue (Update prosemirror-tables to 1.0.0) at prosemirror-utils to address this problem.

@Peter-Krebs
Copy link

Corrected in tiptap@1.26.7, tiptap-extensions@1.28.7
#305 (comment) (also applies to npm install)

@waaronking
Copy link

I'm still getting this warning on tiptap@1.27.1 (with tiptap-extensions@1.29.1). Is there something we need to do, or is this something prosemirror needs to worry about?

@Tumulte
Copy link

Tumulte commented May 24, 2020

Same issue as @waaronking here tiptap is looking for prosemirror-tables@^0.9.1

I must add that it broke my app and if I manually add prosemirror, I have "Duplicate use of selection JSON ID cell"

Hope it’ll be fixed soon !

@hanspagel
Copy link
Contributor

There is nothing we can do about that, prosemirror-utils needs to upgrade the prosemirror-tables dependency. Here is the related PR over there:
atlassian/prosemirror-utils#93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug The issue or pullrequest is related to a bug
Projects
None yet
Development

No branches or pull requests

6 participants