Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canopy moisture content output from GEFSv12 grib2 input has erroneously high canopy water content #481

Closed
LarissaReames-NOAA opened this issue Apr 29, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@LarissaReames-NOAA
Copy link
Collaborator

This issue was noted and fixed by @christinaholtNOAA (and others) in their branch (see commit 11f31c53 in the NCAR fork) by correcting the data in qc_check, but I will instead adjust the input data just after read. This change will be tested with a simple unit test to check that values greater than the max allowed value (0.5) are properly replaced by 0.

@GeorgeGayno-NOAA
Copy link
Collaborator

@LarissaReames-NOAA What exactly is the problem with the grib2 data? Does the land mask not match the data? I suggest we make a list (and some graphics) of all the problems with the grib2 data so it can be fixed.

@LarissaReames-NOAA
Copy link
Collaborator Author

@GeorgeGayno-NOAA I believe this is tied to the same issue as the erroneous soil temperature problems that I addressed in my last PR, so it's already in the pipe at NCO to be fixed. However, we'll still need this in place for compatibility with current and older files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants