-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fortran subprogram gblevents.f from w3emc to UFS_UTILS to solve circular dependency problem in NCEPLIBS? #523
Comments
It's not a program though. Everything else here is an executable. |
I think the fact that it's a library is not a problem. But perhaps it should be in NCEPLIBS-bufr? @jbathegit and @jack-woollen do you guys know about this program? |
I say we track this in the w3emc repo |
If added to UFS_UTILS it will introduce a dependency on NCEPLIBS-bufr, which is new. All other dependencies are already in use by other parts of UFS_UTILS. So that does look like a good fit... |
What I wonder is - who calls this function? |
That, I don't know. I know @BoiVuong-NOAA worked on it. |
I also don't think it would be appropriate here because we don't install UFS_UTILS. Depending on what applications use gblevents.f it wouldn't be available pre-installed. |
Well I really don't want to create a new repo for one subprogram! |
For my part, I don't have any knowledge of or familiarity with this program. But if the main docblock is correct, it looks like it also has dependencies on NCEPLIBS-sigio, NCEPLIBS-sp, and NCEPLIBS-nemsio. |
Although there are certainly some valid objections to putting glbevents into UFS_UTILS (including the fact that UFS_UTILS is not built by hpc-stack), it seems to be the best available option. @Hang-Lei-NOAA will do this in coordination with @GeorgeGayno-NOAA . |
@GeorgeGayno-NOAA we have a fortran subprogram in NCEPLIBS-w3emc which should probably be in UFS_UTILS.
According to @kgerheiser:
The text was updated successfully, but these errors were encountered: