Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fortran subprogram gblevents.f from w3emc to UFS_UTILS to solve circular dependency problem in NCEPLIBS? #523

Closed
edwardhartnett opened this issue May 21, 2021 · 10 comments · Fixed by #536
Assignees
Labels
enhancement New feature or request

Comments

@edwardhartnett
Copy link
Collaborator

edwardhartnett commented May 21, 2021

@GeorgeGayno-NOAA we have a fortran subprogram in NCEPLIBS-w3emc which should probably be in UFS_UTILS.

According to @kgerheiser:

It's that gblevents.f program which uses nemsio and sigio.

https://github.com/NOAA-EMC/NCEPLIBS-w3emc/blob/develop/src/gblevents.f

It seems to me that it should be moved out of w3emc. Into it's own repo? UFS_UTILS? I think it was put there just because that repo is the dumping ground for miscellaneous things. Then, w3emc would have no dependencies.

@kgerheiser
Copy link
Contributor

It's not a program though. Everything else here is an executable.

@edwardhartnett
Copy link
Collaborator Author

edwardhartnett commented May 21, 2021

I think the fact that it's a library is not a problem.

But perhaps it should be in NCEPLIBS-bufr? @jbathegit and @jack-woollen do you guys know about this program?

@kgerheiser
Copy link
Contributor

I say we track this in the w3emc repo

NOAA-EMC/NCEPLIBS-w3emc#71

@edwardhartnett
Copy link
Collaborator Author

If added to UFS_UTILS it will introduce a dependency on NCEPLIBS-bufr, which is new. All other dependencies are already in use by other parts of UFS_UTILS. So that does look like a good fit...

@edwardhartnett edwardhartnett changed the title Add new utility to solve circular dependency problem in NCEPLIBS? Add new fortran subprogram from w3emc to UFS_UTILS to solve circular dependency problem in NCEPLIBS? May 21, 2021
@edwardhartnett edwardhartnett changed the title Add new fortran subprogram from w3emc to UFS_UTILS to solve circular dependency problem in NCEPLIBS? Add fortran subprogram gblevents.f from w3emc to UFS_UTILS to solve circular dependency problem in NCEPLIBS? May 21, 2021
@edwardhartnett
Copy link
Collaborator Author

What I wonder is - who calls this function?

@kgerheiser
Copy link
Contributor

That, I don't know. I know @BoiVuong-NOAA worked on it.

@kgerheiser
Copy link
Contributor

I also don't think it would be appropriate here because we don't install UFS_UTILS. Depending on what applications use gblevents.f it wouldn't be available pre-installed.

@edwardhartnett
Copy link
Collaborator Author

Well I really don't want to create a new repo for one subprogram!

@jbathegit
Copy link

I think the fact that it's a library is not a problem.

But perhaps it should be in NCEPLIBS-bufr? @jbathegit and @jack-woollen do you guys know about this program?

For my part, I don't have any knowledge of or familiarity with this program. But if the main docblock is correct, it looks like it also has dependencies on NCEPLIBS-sigio, NCEPLIBS-sp, and NCEPLIBS-nemsio.

@edwardhartnett
Copy link
Collaborator Author

Although there are certainly some valid objections to putting glbevents into UFS_UTILS (including the fact that UFS_UTILS is not built by hpc-stack), it seems to be the best available option.

@Hang-Lei-NOAA will do this in coordination with @GeorgeGayno-NOAA .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants