Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code to ingest snow increments from JEDI for the Noah-MP model #562

Closed
ClaraDraper-NOAA opened this issue Aug 11, 2021 · 6 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@ClaraDraper-NOAA
Copy link
Contributor

This issue follows from #561, but is now for Noah-MP not Noah.

Noah-MP has a multilayer snow model, and the code to add the increments is more involved. Also, we will not be able to separate out the steps into: 1) update snow depth, 2) adjust other variables, as is done for Noah. I suggest we skip the first step, and use the current code structure (calling code from lsm_routines) to apply the update.

Mike B will do this once Clara has done #561.

@GeorgeGayno-NOAA GeorgeGayno-NOAA added the enhancement New feature or request label Aug 11, 2021
@GeorgeGayno-NOAA
Copy link
Collaborator

@barlage There has not been much activity on this issue. Should I keep it open?

@ClaraDraper-NOAA
Copy link
Contributor Author

I'm doing this outside of UFS_UTILS, as I needed to be able to handle fractional grid cells. However, Jiarui is now integrating my work into EMC's GDAS system, so we should think about how we want to do this. I suggest Mike and I discuss this at our tag-up on Tuesday.

@GeorgeGayno-NOAA Can UFS_UTILS manage fractional grid cells yet?

@GeorgeGayno-NOAA
Copy link
Collaborator

I'm doing this outside of UFS_UTILS, as I needed to be able to handle fractional grid cells. However, Jiarui is now integrating my work into EMC's GDAS system, so we should think about how we want to do this. I suggest Mike and I discuss this at our tag-up on Tuesday.

@GeorgeGayno-NOAA Can UFS_UTILS manage fractional grid cells yet?

Not yet.

@ClaraDraper-NOAA
Copy link
Contributor Author

Thanks @GeorgeGayno-NOAA. We'll get back to you next week.

@ClaraDraper-NOAA
Copy link
Contributor Author

@GeorgeGayno-NOAA Mike and I just had a quick chat about this, and decided to continue doing the Noah-MP snow depth updates outside of UFS_UTILS, so yes, you can close this.

FYI: This is the code currently being used:
https://github.com/NOAA-PSL/land-apply_jedi_incr.git

Long-term we could bring this back into UFS_UTILS once the latter can handle Noah-MP and fractional grids, if this seems appropriate.

@GeorgeGayno-NOAA
Copy link
Collaborator

@GeorgeGayno-NOAA Mike and I just had a quick chat about this, and decided to continue doing the Noah-MP snow depth updates outside of UFS_UTILS, so yes, you can close this.

FYI: This is the code currently being used: https://github.com/NOAA-PSL/land-apply_jedi_incr.git

Long-term we could bring this back into UFS_UTILS once the latter can handle Noah-MP and fractional grids, if this seems appropriate.

Ok. Thanks for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants