Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging in chgres_cube namelist creation. #621

Open
1 task
christinaholtNOAA opened this issue Oct 28, 2024 · 0 comments
Open
1 task

Improve logging in chgres_cube namelist creation. #621

christinaholtNOAA opened this issue Oct 28, 2024 · 0 comments

Comments

@christinaholtNOAA
Copy link
Contributor

AC

  • Log extra information on each item that is required for a task.

Description

Implementation Notes: Potential option to log extra info from task method (not necessarily from the iotaa framework). The first item yielded could contain the key name for the descriptive element. Probably want it to be optional.

When an input file that goes into the chgres_cube's namelist is missing, the user debugging experience would be improved by knowing which key path is related to the missing file. Given that we may have unrendered values in the input config, and that users don't know which keys are being checked as external assets, we'd need to dig into the driver code to understand which of the three empty-string-valued keys (lines 348-350 in the YAML example below) are turned into external assets. As it turns out, there are only two external assets that aren't ready because there's a typo in the key name that includes a '. The schema should catch this and will be fixed as part of the updates needed for SRW integration.

It's also challenging to figure out which key (orog_files_target_grid) has a value that renders to C403_oro_data.tile7.halo4.nc.

Here's an example with the interesting snippet from the full log (below):

[2024-10-07T21:50:19]     INFO 20200810 00Z chgres_cube namelist file fort.41: Checking requirements
[2024-10-07T21:50:19]  WARNING File .: State: Not Ready (external asset)
[2024-10-07T21:50:19]  WARNING File .: State: Not Ready (external asset)
[2024-10-07T21:50:19]  WARNING File C403_oro_data.tile7.halo4.nc: State: Not Ready (external asset)
[2024-10-07T21:50:19]     INFO 20200810 00Z chgres_cube namelist file fort.41: Requirement(s) not ready

The UW YAML for the namelist section that triggered this log message:

341           fix_dir_target_grid: /scratch2/NAGAPE/epic/Brian.Weir/expt_dirs/grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta/fix_lam
342           mosaic_file_target_grid: '{{ workflow.FIXlam }}/{{ ''CRES'' | env }}{{ workflow.DOT_OR_USCORE }}mosaic.halo{{ constants.NH4 }}.nc'
343           orog_dir_target_grid: /scratch2/NAGAPE/epic/Brian.Weir/expt_dirs/grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta/fix_lam
344           orog_files_target_grid: '{{ ''CRES'' | env }}{{ workflow.DOT_OR_USCORE }}oro_data.tile{{ constants.TILE_RGNL }}.halo{{ constants.NH4 }}.nc'
345           vcoord_file_target_grid: /scratch2/NAGAPE/epic/Brian.Weir/expt_dirs/grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta/fix_am/global_hyblev.l65.txt
346           varmap_file: /scratch2/NAGAPE/epic/Brian.Weir/ufs-srweather-app/parm/ufs_utils/varmap_tables/GFSphys_var_map.txt
347           data_dir_input_grid: '{{ task_make_lbcs.chgres_cube.run_dir }}'
348           atm_files_input_grid: ''
349           sfc_files_input_grid': ''
350           grib2_file_input_grid: ''

Full log for reference:

[2024-10-07T21:50:18]     INFO Validating config against internal schema: chgres-cube
[2024-10-07T21:50:18]     INFO 0 UW schema-validation errors found in chgres_cube config
[2024-10-07T21:50:18]     INFO Validating config against internal schema: platform
[2024-10-07T21:50:18]     INFO 0 UW schema-validation errors found in platform config
[2024-10-07T21:50:19]     INFO 20200810 00Z chgres_cube run: Initial state: Not Ready
[2024-10-07T21:50:19]     INFO 20200810 00Z chgres_cube run: Checking requirements
[2024-10-07T21:50:19]     INFO 20200810 00Z chgres_cube run via local execution: Initial state: Not Ready
[2024-10-07T21:50:19]     INFO 20200810 00Z chgres_cube run via local execution: Checking requirements
[2024-10-07T21:50:19]     INFO 20200810 00Z chgres_cube provisioned run directory: Checking requirements
[2024-10-07T21:50:19]     INFO 20200810 00Z chgres_cube namelist file fort.41: Initial state: Not Ready
[2024-10-07T21:50:19]     INFO 20200810 00Z chgres_cube namelist file fort.41: Checking requirements
[2024-10-07T21:50:19]  WARNING File .: State: Not Ready (external asset)
[2024-10-07T21:50:19]  WARNING File .: State: Not Ready (external asset)
[2024-10-07T21:50:19]  WARNING File C403_oro_data.tile7.halo4.nc: State: Not Ready (external asset)
[2024-10-07T21:50:19]     INFO 20200810 00Z chgres_cube namelist file fort.41: Requirement(s) not ready
[2024-10-07T21:50:19]  WARNING 20200810 00Z chgres_cube namelist file fort.41: Final state: Not Ready**
[2024-10-07T21:50:19]     INFO 20200810 00Z chgres_cube runscript.chgres_cube: Initial state: Not Ready
[2024-10-07T21:50:19]     INFO 20200810 00Z chgres_cube runscript.chgres_cube: Checking requirements
[2024-10-07T21:50:19]     INFO 20200810 00Z chgres_cube runscript.chgres_cube: Requirement(s) ready
[2024-10-07T21:50:19]     INFO 20200810 00Z chgres_cube runscript.chgres_cube: Executing
[2024-10-07T21:50:19]     INFO 20200810 00Z chgres_cube runscript.chgres_cube: Final state: Ready
[2024-10-07T21:50:19]  WARNING 20200810 00Z chgres_cube provisioned run directory: Final state: Not Ready
[2024-10-07T21:50:19]     INFO 20200810 00Z chgres_cube run via local execution: Requirement(s) not ready
[2024-10-07T21:50:19]  WARNING 20200810 00Z chgres_cube run via local execution: Final state: Not Ready
[2024-10-07T21:50:19]  WARNING 20200810 00Z chgres_cube run: Final state: Not Ready
Will run in /scratch2/NAGAPE/epic/Brian.Weir/expt_dirs/grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta/2020081000/tmp_MAKE_ICS
Error occurred running chgres_cube. Please see component error logs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant