Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default output() method to Driver base class #616

Merged
merged 6 commits into from
Oct 22, 2024
Merged

Add default output() method to Driver base class #616

merged 6 commits into from
Oct 22, 2024

Conversation

maddenp-noaa
Copy link
Collaborator

Synopsis

Fixes #615.

Type

  • Documentation
  • Enhancement (adds new functionality)

Impact

  • This is a non-breaking change (existing functionality continues to work as expected)

Checklist

  • I have added myself and any co-authors to the PR's Assignees list.
  • I have reviewed the documentation and have made any updates necessitated by this change.

@maddenp-noaa maddenp-noaa self-assigned this Oct 22, 2024
maddenp-noaa
maddenp-noaa commented Oct 22, 2024
View reviewed changes
docs/sections/user_guide/cli/drivers/chgres_cube/help.out Show resolved Hide resolved
src/uwtools/drivers/driver.py Show resolved Hide resolved
src/uwtools/drivers/driver.py Show resolved Hide resolved
src/uwtools/exceptions.py Show resolved Hide resolved
src/uwtools/tests/drivers/test_cdeps.py Show resolved Hide resolved
src/uwtools/tests/drivers/test_driver.py Show resolved Hide resolved
src/uwtools/tests/drivers/test_driver.py Show resolved Hide resolved
src/uwtools/tests/drivers/test_driver.py Show resolved Hide resolved
src/uwtools/tests/drivers/test_driver.py Show resolved Hide resolved
src/uwtools/tests/drivers/test_esg_grid.py Show resolved Hide resolved
@maddenp-noaa maddenp-noaa marked this pull request as ready for review October 22, 2024 17:31
christinaholtNOAA
christinaholtNOAA approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@christinaholtNOAA christinaholtNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/uwtools/drivers/driver.py Show resolved Hide resolved
NaureenBharwaniNOAA
NaureenBharwaniNOAA approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@NaureenBharwaniNOAA NaureenBharwaniNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

elcarpenterNOAA
elcarpenterNOAA approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@elcarpenterNOAA elcarpenterNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

src/uwtools/drivers/driver.py Show resolved Hide resolved
WeirAE
WeirAE approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@WeirAE WeirAE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maddenp-noaa maddenp-noaa merged commit 9963a36 into ufs-community:main Oct 22, 2024
2 checks passed
@maddenp-noaa maddenp-noaa deleted the gh615-driver-output branch October 22, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elcarpenterNOAA elcarpenterNOAA elcarpenterNOAA approved these changes

@NaureenBharwaniNOAA NaureenBharwaniNOAA NaureenBharwaniNOAA approved these changes

@WeirAE WeirAE WeirAE approved these changes

@christinaholtNOAA christinaholtNOAA christinaholtNOAA approved these changes

@fgabelmannjr fgabelmannjr Awaiting requested review from fgabelmannjr

@Byrnetp Byrnetp Awaiting requested review from Byrnetp Byrnetp is a code owner

Assignees

@maddenp-noaa maddenp-noaa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add output method for base driver class.
5 participants
@maddenp-noaa @christinaholtNOAA @WeirAE @NaureenBharwaniNOAA @elcarpenterNOAA