Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use local fonts instead of Google #518

Closed
meirroth opened this issue Mar 1, 2021 · 3 comments · Fixed by #677 or #694
Closed

Use local fonts instead of Google #518

meirroth opened this issue Mar 1, 2021 · 3 comments · Fixed by #677 or #694
Labels
enhancement New feature or request

Comments

@meirroth
Copy link
Contributor

meirroth commented Mar 1, 2021

I assume most if not a lot of people using umami are doing so to avoid Google because of privacy concerns. that's why I suggest adding a Environment variable like: LOCAL_FONTS for example, that will load local hosted fonts instead of from Google servers.
Or removing google fonts entirely and host the fonts locally by default.

I am willing to create a pull request if this is something you accept.

(This tool can help: https://google-webfonts-helper.herokuapp.com/fonts)

Code reference:
https://github.com/mikecao/umami/blob/0b8336f10354e3c11c0146ef74155cd35fd9085e/components/layout/Layout.js#L13
https://github.com/mikecao/umami/blob/c881751e4f3c77fc9246758519a88142cb3e58c5/components/settings/LanguageButton.js#L20-L29

@mikecao mikecao added the enhancement New feature or request label Mar 3, 2021
@MoltenCoffee
Copy link
Contributor

Big supporter of this! Google Fonts has relatively aggressive caching headers, caching for about a year, so the privacy implications are mild, but I'd still favour including them.

@rogerclotet
Copy link
Contributor

I'm guessing this can be closed now 😄

@meirroth
Copy link
Contributor Author

I'm guessing this can be closed now 😄

Thank you @rogerclotet !

@mikecao mikecao mentioned this issue Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants