You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adding region and partition ids as a prefix to log statements would help readability. Unfortunately it looks like GLOG does not support custom prefixes: google/glog#229 (comment). We could write a wrapper for the log macro? Might be more work than it's worth?
I thought about this before but we only need this in unit tests because the logs are interleaved in one terminal. Later on when things are more stable, however, we'll most often run different processes with logging on different terminals; or run with Docker, and log of a particular process can be watched with docker container logs
Moreover, in the tests, partition and replica are not global variables so you need to implement the wrapper such that it takes in the config object, which might get complicated quite fast.
Adding region and partition ids as a prefix to log statements would help readability. Unfortunately it looks like GLOG does not support custom prefixes: google/glog#229 (comment). We could write a wrapper for the log macro? Might be more work than it's worth?
@ctring
The text was updated successfully, but these errors were encountered: