Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add region/partition information as a prefix to log statements #9

Closed
johannkm opened this issue Feb 13, 2020 · 1 comment
Closed

Add region/partition information as a prefix to log statements #9

johannkm opened this issue Feb 13, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@johannkm
Copy link
Collaborator

johannkm commented Feb 13, 2020

Adding region and partition ids as a prefix to log statements would help readability. Unfortunately it looks like GLOG does not support custom prefixes: google/glog#229 (comment). We could write a wrapper for the log macro? Might be more work than it's worth?

@ctring

@johannkm johannkm added the enhancement New feature or request label Feb 13, 2020
@ctring
Copy link
Collaborator

ctring commented Feb 13, 2020

I thought about this before but we only need this in unit tests because the logs are interleaved in one terminal. Later on when things are more stable, however, we'll most often run different processes with logging on different terminals; or run with Docker, and log of a particular process can be watched with docker container logs

Moreover, in the tests, partition and replica are not global variables so you need to implement the wrapper such that it takes in the config object, which might get complicated quite fast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants