fix(ssr): html with single quote parse error #6066

ycjcl868 · 2021-01-23T05:07:51Z

Close #5980

Checklist

npm test passes
tests are included
documentation is changed or added
commit message follows commit guidelines

Description of change

any feature?
close https://github.com/umijs/umi/ISSUE_URL

ycjcl868 · 2021-01-23T05:09:18Z

/version

github-actions · 2021-01-23T05:10:30Z

♻️ Hi, It's time to update the npm package!

78 npm packages are outdated.
Let's begin maintenance to maintain a fresh package!

Packages

---

⚠️ Major (43 packages)

Package	Current	Wanted	Latest	Workspace	Type	CHANGELOG
@hapi/joi	`16.1.8`	`16.1.8`	`17.1.1`	`@umijs/core`	`dependencies`	-
@hapi/joi	`16.1.8`	`16.1.8`	`17.1.1`	`@umijs/preset-built-in`	`dependencies`	-
@svgr/webpack	`4.3.3`	`4.3.3`	`5.5.0`	`@umijs/babel-preset-umi`	`dependencies`	-
@testing-library/react	`10.4.9`	`10.4.9`	`11.2.3`	``	`devDependencies`	-
@types/hapi__joi	`16.0.12`	`16.0.12`	`17.1.6`	`@umijs/core`	`dependencies`	-
@types/react	`16.14.2`	`16.14.2`	`17.0.0`	`@umijs/renderer-mpa`	`dependencies`	-
@types/react	`16.14.2`	`16.14.2`	`17.0.0`	`@umijs/renderer-react`	`dependencies`	-
@types/react-dom	`16.9.10`	`16.9.10`	`17.0.0`	`@umijs/renderer-mpa`	`dependencies`	-
@types/react-dom	`16.9.10`	`16.9.10`	`17.0.0`	`@umijs/renderer-react`	`dependencies`	-
@types/serialize-javascript	`4.0.0`	`4.0.0`	`5.0.0`	`@umijs/preset-built-in`	`dependencies`	-
@types/webpack-dev-middleware	`3.7.2`	`3.7.2`	`4.1.0`	`@umijs/bundler-webpack`	`dependencies`	-
@types/yargs-parser	`15.0.0`	`15.0.0`	`20.2.0`	`@umijs/utils`	`dependencies`	-
babel-jest	`25.5.1`	`25.5.1`	`26.6.3`	`@umijs/test`	`dependencies`	-
cliui	`6.0.0`	`6.0.0`	`7.0.4`	`@umijs/preset-built-in`	`dependencies`	-
copy-webpack-plugin	`6.1.0`	`6.1.0`	`7.0.0`	`@umijs/bundler-webpack`	`dependencies`	-
css-loader	`3.6.0`	`3.6.0`	`5.0.1`	`@umijs/bundler-webpack`	`dependencies`	-
execa	`4.0.3`	`4.0.3`	`5.0.0`	`@umijs/utils`	`dependencies`	-
got	`9.6.0`	`9.6.0`	`11.8.1`	`@umijs/utils`	`dependencies`	-
immer	`7.0.5`	`7.0.5`	`8.0.1`	`@umijs/server`	`dependencies`	-
jest	`25.5.4`	`25.5.4`	`26.6.3`	`@umijs/test`	`dependencies`	-
jest-cli	`25.5.4`	`25.5.4`	`26.6.3`	`@umijs/test`	`dependencies`	-
less	`3.12.2`	`3.12.2`	`4.1.0`	`@umijs/bundler-webpack`	`dependencies`	-
less-loader	`5.0.0`	`5.0.0`	`7.3.0`	`@umijs/bundler-webpack`	`dependencies`	-
loader-utils	`1.4.0`	`1.4.0`	`2.0.0`	`@umijs/bundler-webpack`	`dependencies`	-
mini-css-extract-plugin	`0.12.0`	`0.12.0`	`1.3.4`	`@umijs/bundler-webpack`	`dependencies`	-
normalize-url	`1.9.1`	`1.9.1`	`5.3.0`	`@umijs/bundler-webpack`	`dependencies`	-
path-to-regexp	`1.8.0`	`1.8.0`	`6.2.0`	`@umijs/preset-built-in`	`dependencies`	-
postcss	`7.0.32`	`7.0.32`	`8.2.4`	`@umijs/bundler-webpack`	`dependencies`	-
postcss-flexbugs-fixes	`4.2.1`	`4.2.1`	`5.0.2`	`@umijs/bundler-webpack`	`dependencies`	-
postcss-loader	`3.0.0`	`3.0.0`	`4.2.0`	`@umijs/bundler-webpack`	`dependencies`	-
postcss-safe-parser	`4.0.2`	`4.0.2`	`5.0.2`	`@umijs/bundler-webpack`	`dependencies`	-
react	`16.14.0`	`16.14.0`	`17.0.1`	`umi`	`dependencies`	-
react-dom	`16.14.0`	`16.14.0`	`17.0.1`	`umi`	`dependencies`	-
schema-utils	`1.0.0`	`1.0.0`	`3.0.0`	`@umijs/bundler-webpack`	`dependencies`	-
style-loader	`1.3.0`	`1.3.0`	`2.0.0`	`@umijs/bundler-webpack`	`dependencies`	-
tapable	`1.1.3`	`1.1.3`	`2.2.0`	`@umijs/core`	`dependencies`	-
terser-webpack-plugin	`4.2.3`	`4.2.3`	`5.1.1`	`@umijs/bundler-webpack`	`dependencies`	-
webpack	`4.44.1`	`4.44.1`	`5.17.0`	`@umijs/bundler-webpack`	`dependencies`	-
webpack-dev-middleware	`3.7.2`	`3.7.2`	`4.1.0`	`@umijs/bundler-webpack`	`dependencies`	-
webpack-manifest-plugin	`2.2.0`	`2.2.0`	`3.0.0`	`@umijs/bundler-webpack`	`dependencies`	-
webpack-sources	`1.4.3`	`1.4.3`	`2.2.0`	`@umijs/bundler-webpack`	`dependencies`	-
yargs	`15.4.1`	`15.4.1`	`16.2.0`	`@umijs/utils`	`dependencies`	-
yargs-parser	`18.1.3`	`18.1.3`	`20.2.4`	`@umijs/utils`	`dependencies`	-

⚡ Minor (10 packages)

Package	Current	Wanted	Latest	Type	CHANGELOG
@babel/core	`7.10.4`	`7.10.4`	`7.12.10`	`devDependencies`	-
@types/babel__traverse	`7.0.13`	`7.0.13`	`7.11.0`	`devDependencies`	-
@types/node	`14.0.23`	`14.0.23`	`14.14.22`	`dependencies`	-
@types/sockjs-client	`1.1.1`	`1.1.1`	`1.5.0`	`dependencies`	-
@types/webpack-bundle-analyzer	`3.8.0`	`3.8.0`	`3.9.0`	`dependencies`	-
chokidar	`3.4.3`	`3.4.3`	`3.5.1`	`dependencies`	-
core-js	`3.6.5`	`3.6.5`	`3.8.3`	`dependencies`	-
fork-ts-checker-webpack-plugin	`6.0.5`	`6.0.5`	`6.1.0`	`dependencies`	-
regenerator-runtime	`0.13.5`	`0.13.5`	`0.13.7`	`dependencies`	-
use-subscription	`1.4.1`	`1.4.1`	`1.5.1`	`dependencies`	-

🔰 Patch (25 packages)

Package	Current	Wanted	Latest	Workspace	Type	CHANGELOG
@babel/plugin-proposal-decorators	`7.12.1`	`7.12.1`	`7.12.12`	`@umijs/babel-preset-umi`	`dependencies`	-
@babel/plugin-proposal-optional-chaining	`7.12.1`	`7.12.1`	`7.12.7`	`@umijs/babel-preset-umi`	`dependencies`	-
@babel/plugin-transform-runtime	`7.12.1`	`7.12.1`	`7.12.10`	`@umijs/babel-preset-umi`	`dependencies`	-
@babel/preset-env	`7.12.1`	`7.12.1`	`7.12.11`	`@umijs/babel-preset-umi`	`dependencies`	-
@babel/preset-react	`7.12.1`	`7.12.1`	`7.12.10`	`@umijs/babel-preset-umi`	`dependencies`	-
@babel/preset-typescript	`7.12.1`	`7.12.1`	`7.12.7`	`@umijs/babel-preset-umi`	`dependencies`	-
@babel/traverse	`7.12.5`	`7.12.5`	`7.12.12`	`@umijs/babel-plugin-auto-css-modules`	`devDependencies`	-
@babel/traverse	`7.12.5`	`7.12.5`	`7.12.12`	`@umijs/babel-plugin-import-to-await-require`	`devDependencies`	-
@babel/types	`7.12.6`	`7.12.6`	`7.12.12`	`@umijs/babel-plugin-auto-css-modules`	`devDependencies`	-
@babel/types	`7.12.6`	`7.12.6`	`7.12.12`	`@umijs/babel-plugin-import-to-await-require`	`dependencies`	-
@types/babel__core	`7.1.9`	`7.1.9`	`7.1.12`	``	`devDependencies`	-
@types/express	`4.17.7`	`4.17.7`	`4.17.11`	`@umijs/server`	`dependencies`	-
@types/express	`4.17.7`	`4.17.7`	`4.17.11`	`@umijs/types`	`dependencies`	-
@types/lodash	`4.14.167`	`4.14.167`	`4.14.168`	`@umijs/utils`	`dependencies`	-
@types/multer	`1.4.3`	`1.4.3`	`1.4.5`	`@umijs/preset-built-in`	`dependencies`	-
@types/mustache	`4.1.0`	`4.1.0`	`4.1.1`	`@umijs/utils`	`dependencies`	-
@types/node	`14.14.21`	`14.14.22`	`14.14.22`	``	`devDependencies`	-
@types/react-router	`5.1.8`	`5.1.8`	`5.1.11`	`@umijs/runtime`	`dependencies`	-
@types/react-router-config	`5.0.1`	`5.0.1`	`5.0.2`	`@umijs/preset-built-in`	`dependencies`	-
@types/react-router-dom	`5.1.5`	`5.1.5`	`5.1.7`	`@umijs/runtime`	`dependencies`	-
@types/webpack	`4.41.25`	`4.41.25`	`4.41.26`	`@umijs/bundler-webpack`	`dependencies`	-
@types/webpack	`4.41.21`	`4.41.21`	`4.41.26`	`@umijs/types`	`dependencies`	-
@umijs/preset-dumi	`1.1.0`	`1.1.3`	`1.1.3`	``	`devDependencies`	-
core-js	`3.8.2`	`3.8.2`	`3.8.3`	`@umijs/test`	`dependencies`	-
portfinder	`1.0.26`	`1.0.26`	`1.0.28`	`@umijs/server`	`dependencies`	-

codecov · 2021-01-23T07:37:18Z

Codecov Report

Merging #6066 (1724f84) into master (4794c75) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #6066   +/-   ##
=======================================
  Coverage   82.94%   82.94%           
=======================================
  Files         158      158           
  Lines        3501     3501           
  Branches      941      943    +2     
=======================================
  Hits         2904     2904           
+ Misses        588      587    -1     
- Partials        9       10    +1

Impacted Files	Coverage Δ
...es/preset-built-in/src/plugins/features/ssr/ssr.ts	`45.53% <ø> (ø)`
...atures/ssr/templates/renderServer/renderServer.tsx	`91.89% <0.00%> (ø)`
packages/core/src/Config/Config.ts	`61.78% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4794c75...1724f84. Read the comment docs.

fix: ssr html single quote

c69f5a0

ycjcl868 added 25 commits January 23, 2021 13:14

chore: test

2e9932f

chore: babel parser

173c950

chore: test case

19dca10

chore: test

23459e4

chore: test

db0f32d

chore: test case

53c5eda

chore: types

5abe929

chore: test case

b49fc4d

chore: test

c4be3ed

chore: test

dc345e8

chore: import

75569f5

chore: test

9ae25ae

chore: test

d566abb

chore: test

5647c49

chore: test

debd38f

chore: test

0eaf207

chore: test case

35d481e

chore: test case

c3b850b

chore: test

733c494

chore: test

69eb983

chore: test

44f7785

chore: test

ac93a6e

chore: test case

f67e38c

chore: test

b07a1be

chore: test

1724f84

ycjcl868 changed the title ~~fix: ssr html single quote~~ fix(ssr): html with single quote parse error Jan 24, 2021

ycjcl868 mentioned this pull request Jan 26, 2021

chore: github action upgrade comment umijs/plugins#522

Merged

sorrycc merged commit bff5173 into master Jan 27, 2021

delete-merged-branch bot deleted the fix-ssr-html-single-quote branch January 27, 2021 02:00

This was referenced Mar 16, 2021

build(deps-dev): bump @umijs/test from 3.3.7 to 3.3.10 arvinxx/components#22

Merged

build(deps-dev): bump @umijs/test from 3.2.5 to 3.3.10 liujiayii/dumi_blog#133

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ssr): html with single quote parse error #6066

fix(ssr): html with single quote parse error #6066

ycjcl868 commented Jan 23, 2021 •

edited

Loading

ycjcl868 commented Jan 23, 2021

github-actions bot commented Jan 23, 2021 •

edited by ycjcl868

Loading

codecov bot commented Jan 23, 2021 •

edited

Loading

fix(ssr): html with single quote parse error #6066

fix(ssr): html with single quote parse error #6066

Conversation

ycjcl868 commented Jan 23, 2021 • edited Loading

Checklist

Description of change

ycjcl868 commented Jan 23, 2021

github-actions bot commented Jan 23, 2021 • edited by ycjcl868 Loading

♻️ Hi, It's time to update the npm package!

⚠️ Major (43 packages)

⚡ Minor (10 packages)

🔰 Patch (25 packages)

codecov bot commented Jan 23, 2021 • edited Loading

Codecov Report

ycjcl868 commented Jan 23, 2021 •

edited

Loading

github-actions bot commented Jan 23, 2021 •

edited by ycjcl868

Loading

codecov bot commented Jan 23, 2021 •

edited

Loading