Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use props.location #6101

Merged
merged 1 commit into from
Feb 23, 2021
Merged

feat: use props.location #6101

merged 1 commit into from
Feb 23, 2021

Conversation

yunsii
Copy link
Contributor

@yunsii yunsii commented Jan 31, 2021

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change
  • use Switch and Route props.location

@yunsii
Copy link
Contributor Author

yunsii commented Jan 31, 2021

#4425 (comment)

@codecov
Copy link

codecov bot commented Jan 31, 2021

Codecov Report

Merging #6101 (bda29d2) into master (10b4e02) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6101   +/-   ##
=======================================
  Coverage   82.94%   82.94%           
=======================================
  Files         158      158           
  Lines        3501     3501           
  Branches      941      922   -19     
=======================================
  Hits         2904     2904           
  Misses        588      588           
  Partials        9        9           
Impacted Files Coverage Δ
packages/renderer-react/src/renderRoutes/Route.tsx 81.81% <100.00%> (ø)
...ackages/renderer-react/src/renderRoutes/Switch.tsx 94.11% <100.00%> (ø)
...s/renderer-react/src/renderRoutes/renderRoutes.tsx 96.82% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10b4e02...bda29d2. Read the comment docs.

@ycjcl868 ycjcl868 requested a review from sorrycc February 1, 2021 02:31
@yunsii
Copy link
Contributor Author

yunsii commented Feb 16, 2021

#4425 (comment) 路由切换动画也会有问题

@yunsii
Copy link
Contributor Author

yunsii commented Feb 18, 2021

@ycjcl868 大佬,这个问题啥时候能确定一下啊?在钉钉群里也艾特云谦大佬了,一直没消息,自己的项目挺想升级 umi 3.x 的 _(:3J∠)_

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants