Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problematic logout doesn't show errors in the UI #1455

Open
paskal opened this issue Jul 31, 2022 · 3 comments
Open

Problematic logout doesn't show errors in the UI #1455

paskal opened this issue Jul 31, 2022 · 3 comments

Comments

@paskal
Copy link
Collaborator

paskal commented Jul 31, 2022

I run remark42 like that: ./remark42.darwin-arm64 server --secret=12345 --url=http://127.0.0.1:8080.

If I was logged in before running that version (with no auth providers) I see a normal comment screen:

image

If I push the "log out" button, http://127.0.0.1:8080/auth/logout?site=remark request is made with status code 400 which has the following answer:

{
    "error": "providers not defined"
}

The interface shows nothing. In the console, I see the following:

image

Erroring code:

image

@akellbl4
Copy link
Collaborator

akellbl4 commented Aug 1, 2022

I think it could be composed with #1456
the point is the same. we do not support 0 auth providers.

@paskal
Copy link
Collaborator Author

paskal commented Aug 1, 2022

The scenario I described is the most straightforward way of producing the problem. The real issue is the lack of proper error handling on the logout button push in the frontend.

@akellbl4
Copy link
Collaborator

Maybe it is not only about logout btw, but handling errors on requests to server in general. I know we handle most of errors but probably we have several cases where we don't.

The specific of logout made me think of this bizarre case, because severity of described case is going to 0%.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants