Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'to yield exchange satisfying' not documented #17

Open
msiebuhr opened this issue Sep 13, 2017 · 10 comments
Open

'to yield exchange satisfying' not documented #17

msiebuhr opened this issue Sep 13, 2017 · 10 comments

Comments

@msiebuhr
Copy link

'<function> to yield exchange satisfying <any>', // Please prefer this one because it does use 'to satisfy' semantics

Comment says Please prefer this one because it does use 'to satisfy' semantics, so I guess it is important :)

@papandreou
Copy link
Member

Damn, there isn't even a documentation site for unexpected-express. It's probably the plugin that I use most often myself, maybe except for unexpected-sinon. Skomagerens børn går i hullede sko...

@msiebuhr
Copy link
Author

http://unexpected.js.org/unexpected-express/ was what I had in mind...

@papandreou
Copy link
Member

Right, that's there, but there's no structured docs for the individual assertions (yet).

You're right, we should change the examples to use to yield exchange satisfying. If you have the time, the source is here: https://github.com/unexpectedjs/unexpected-express/blob/master/documentation/index.md

@joelmukuthu
Copy link
Member

From the code, I'm guessing to yield exchange exhaustively satisfying is not supported?

@papandreou
Copy link
Member

@joelmukuthu Correct! Have you found yourself needing that?

@joelmukuthu
Copy link
Member

I'm introducing unexpected-express at my job and I'd like to make it possible to have exhaustive satisfactions for the new-comers (possibly to avoid omissions). I actually don't know how it would work, having to describe everything in the req/res but I just wanted to know if it's supported. Don't need it per se

@papandreou
Copy link
Member

The exhaustiveness would only apply to the response part, as the request part is specifying the input, which per definition is exhaustive. Right?

@joelmukuthu
Copy link
Member

Indeed, correct!

@papandreou
Copy link
Member

Well, it would be a useful addition, and probably not very hard. PR welcome :)

@joelmukuthu
Copy link
Member

Cool, will find some time to try it out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants