Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error out when unsupported keys are supplied #26

Open
papandreou opened this issue Aug 29, 2016 · 0 comments
Open

Error out when unsupported keys are supplied #26

papandreou opened this issue Aug 29, 2016 · 0 comments

Comments

@papandreou
Copy link
Member

I just accidentally did this:

expect(..., 'with http mocked out', [
    ...,
    { url: 'DELETE http://foo.bar/quux' },
    ...
], ...);

Which should have been { request: { url: 'DELETE http://foo.bar/quux' } }. It was interpreted to mean "here any request should happen, I don't care what it looks like, just reply with a 200".

Let's go through it and ensure that we error out when any unsupported property is passed, sort of like https://github.com/unexpectedjs/unexpected-express/blob/master/lib/unexpectedExpress.js#L171-L176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant