Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This package should be published pre-compiled #2

Closed
boonpflug opened this issue Mar 27, 2018 · 5 comments
Closed

This package should be published pre-compiled #2

boonpflug opened this issue Mar 27, 2018 · 5 comments

Comments

@boonpflug
Copy link

As of now this is not building in minified builds/

@ungoldman
Copy link
Owner

Hi @boonpflug! What is the compilation target you are trying to use this for? This module was designed for use in a node 8+ environment, but with something like browserify, babel, or webpack, it should be compilable for browser environments like most other node modules out there.

@SinZ163
Copy link

SinZ163 commented Jun 5, 2018

The minifer that webpack uses doesn't understand ES6 syntax so it falls over on pretty much every line in this library (string templates, array / object destructuring, etc) and create-react-app tells developers to go to libraries (like this) and tell them to ship ES5 compatible builds

@henrikbjorn
Copy link

Normally with Webpack one would exclude /node_modules/ from babel-loader. I am running into the same problem.

@ungoldman
Copy link
Owner

Hi folks, I understand the concern.

I am open to converting this library to ES5 to help with this issue.

I'd rather not introduce a build step to avoid over-complicating maintenance of a very small module.

@ungoldman
Copy link
Owner

This module was converted to ES5 in 86c791e.

The change was released in v1.2.0.

🖖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants