Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-15275 ST forum stuck on loading if user lacks permission #1682

Closed
wants to merge 1 commit into from

Conversation

btangmu
Copy link
Member

@btangmu btangmu commented Jan 10, 2022

-Replace non-existent params.special.showError with simple inline error message

-Two new subroutines loadBad and loadOk

CLDR-15275

  • This PR completes the ticket.

-Replace non-existent params.special.showError with simple inline error message

-Two new subroutines loadBad and loadGood
@btangmu btangmu self-assigned this Jan 10, 2022
@btangmu
Copy link
Member Author

btangmu commented Jan 10, 2022

Error in "Lint Ansible Playbook": "ImportError: cannot import name 'render_group' from 'rich.console' (/usr/local/lib/python3.8/site-packages/rich/console.py)"

What does that mean?

@btangmu
Copy link
Member Author

btangmu commented Jan 10, 2022

I've just tried "re-run all jobs"

@btangmu
Copy link
Member Author

btangmu commented Jan 10, 2022

@srl295 any idea what the error means?

@btangmu btangmu requested a review from srl295 January 10, 2022 21:48
@btangmu
Copy link
Member Author

btangmu commented Jan 10, 2022

Here's something: ansible/ansible-lint#1795

@srl295
Copy link
Member

srl295 commented Jan 10, 2022

Here's something: ansible-community/ansible-lint#1795

yes i just found that.

I'll work on a patch to incorporate that ver until the action catches up

@srl295
Copy link
Member

srl295 commented Jan 10, 2022

Here's something: ansible-community/ansible-lint#1795

yes i just found that.

I'll work on a patch to incorporate that ver until the action catches up

patch: #1682

@btangmu
Copy link
Member Author

btangmu commented Jan 11, 2022

Here goes "re-run all jobs" again...

@srl295
Copy link
Member

srl295 commented Jan 11, 2022

Here goes "re-run all jobs" again...

you can try but you you may need to rebase it on main if you wanted my other changes

@btangmu
Copy link
Member Author

btangmu commented Jan 11, 2022

See #1684

@btangmu btangmu closed this Jan 11, 2022
@srl295
Copy link
Member

srl295 commented Jan 11, 2022

@btangmu you don't need a new PR… just rebase

@btangmu
Copy link
Member Author

btangmu commented Jan 11, 2022

@SRL "just rebase" -- there was also a problem with my commit message and I wanted a clean start :-)

@btangmu btangmu deleted the t15275_a branch January 11, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants