Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing docs for icu_locid #1028

Closed
gregtatum opened this issue Aug 30, 2021 · 1 comment · Fixed by #2113
Closed

Add missing docs for icu_locid #1028

gregtatum opened this issue Aug 30, 2021 · 1 comment · Fixed by #2113
Assignees
@echeran
Labels
C-locale Component: Locale identifiers, BCP47 S-small Size: One afternoon (small bug fix or enhancement) T-docs-tests Type: Code change outside core library
Milestone
ICU4X 1.0 (Polish)

Comments

@gregtatum
Copy link
Member

Remove all #[allow(missing_docs)] suppressions in icu_locid.

Blocks #686.
@gregtatum gregtatum added S-small Size: One afternoon (small bug fix or enhancement) C-locale Component: Locale identifiers, BCP47 labels Aug 30, 2021
@sffc sffc added the T-docs-tests Type: Code change outside core library label Sep 16, 2021
@sffc sffc assigned nciric and unassigned zbraniecki Sep 16, 2021
@sffc sffc added this to the ICU4X 0.4 milestone Sep 16, 2021
@sapriyag sapriyag modified the milestones: ICU4X 0.4, ICU4X 0.5 Oct 26, 2021
@sffc sffc modified the milestones: ICU4X 0.5, ICU4X 0.6 Jan 27, 2022
@sffc
Copy link
Member

sffc commented Jan 27, 2022

@nciric Would you consider adding this to a specific sprint?

@sffc sffc modified the milestones: ICU4X 0.6, ICU4X 1.0 (Polish) May 25, 2022
@sffc sffc mentioned this issue Jun 24, 2022
Closed
@echeran echeran mentioned this issue Jun 25, 2022
Merged
@sffc sffc assigned echeran and unassigned nciric and sapriyag Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@echeran echeran

Labels
C-locale Component: Locale identifiers, BCP47 S-small Size: One afternoon (small bug fix or enhancement) T-docs-tests Type: Code change outside core library
Projects
None yet
Milestone
ICU4X 1.0 (Polish)
Development

Successfully merging a pull request may close this issue.

Add docs in locid to replace missing_docs warning suppressions echeran/icu4x
6 participants
@zbraniecki @echeran @sffc @gregtatum @nciric @sapriyag