Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta-issue: 0.6 Release #1861

Closed
3 tasks done
dminor opened this issue May 5, 2022 · 12 comments · Fixed by #1869 or #1871
Closed
3 tasks done

Meta-issue: 0.6 Release #1861

dminor opened this issue May 5, 2022 · 12 comments · Fixed by #1869 or #1871
Assignees
Labels
C-meta Component: Relating to ICU4X as a whole
Milestone

Comments

@dminor
Copy link
Contributor

dminor commented May 5, 2022

This issue exists to track the 0.6 release

Blockers:

  • Birds eye view of coverage/docs/etc
  • Final check with component owners
  • Final check that no utils have had changes since release
@dminor dminor self-assigned this May 5, 2022
@dminor
Copy link
Contributor Author

dminor commented May 6, 2022

Tracking various utils:

  • codepointtrie: 0.4.0, from c83c90c. API change in 29a3028, major bump
  • crlify: New component, needs first publish
  • deduplicating_array: 0.1.1, from c83c90c, internal changes for linting only, minor bump
  • fixed_decimal: 0.3.0, from 4d98ad7. API change in d9756b8, major bump
  • litemap: 0.4, 4d98ad7. New APIs only, but we didn't do a major bump last time, think we should this time.
  • pattern: 0.1.2, 6975267. internal changes for linting only, minor bump
  • tinystr, 0.6.0, from bede060, API changes, major bump
  • uniset: 0.5.0 4d98ad7, renamed a feature, major bump
  • writeable: 0.4.0, from 4d98ad7, API changed, major bump
  • yoke: 0.5.0, a52b2f6. Unchanged from bump to 0.5.0
  • yoke-derive: 0.5.0, from a52b2f6, Unchanged from bump to 0.5.0
  • zerofrom: 0.1.0, Unchanged.
  • zerovec: 0.7.0, from 4d98ad7, API changed, major bump

@Manishearth
Copy link
Member

  • zerofrom: 0.1.0, new component, needs first publish

It's already published

also, we probably need to do crabbake too

The rest looks right

@dminor
Copy link
Contributor Author

dminor commented May 9, 2022

@Manishearth crabbake is still in experimental... should we move it to utils and then publish it?

@Manishearth
Copy link
Member

Yes

@Manishearth
Copy link
Member

Actually, don't yet since there are PRs changing it. Just publish it from experimental/, we already do that for a bunch of crates

@dminor
Copy link
Contributor Author

dminor commented May 9, 2022

Crabbake will be 0.4.0, we've published a 0.1.0 to reserve the name

This was linked to pull requests May 10, 2022
@dminor
Copy link
Contributor Author

dminor commented May 10, 2022

The release is here https://github.com/unicode-org/icu4x/releases/tag/icu%400.6.0.

I'm in the process of publishing crates, unfortunately we have had a few that were not owned by icu4x-release

@Manishearth
Copy link
Member

Note for the future: we shouldn't tag a release until everything is published since there's a slight chance failures in cargo publish (e.g. if the versions don't match up just right) require further commits), and tags are permanent.

Cargo publish does have a --dry-run mode but unfortunately it does not work at the workspace level — you cannot get it to do a dry run "assuming all dependent crates in this workspace have been published"

@dminor
Copy link
Contributor Author

dminor commented May 10, 2022

I'll update the instructions in release process document

@eugenesvk
Copy link

I think the dependency version in the intro.md tutorial should be update to 0.6 once the crate is published, currently it's 0.2:

[dependencies]
icu = "0.2"

I was doing this tutorial and was puzzled why I was getting errors importing icu::locid::locale as stated in the example in chapter 4 and then realized that this macro only appeared in the version 0.6, but this version isn't yet published at crates.io (and maybe the import command should change to icu::locid::macros::locale?)

@Manishearth
Copy link
Member

Is everything done here?

@dminor dminor added this to the ICU4X 0.6 milestone May 26, 2022
@dminor
Copy link
Contributor Author

dminor commented May 26, 2022

@dminor dminor closed this as completed May 26, 2022
@sffc sffc added the C-meta Component: Relating to ICU4X as a whole label Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-meta Component: Relating to ICU4X as a whole
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants