Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that the provider performs correct non-Chinese collation alias mapping #1965

Open
hsivonen opened this issue May 30, 2022 · 5 comments
Assignees
Labels
C-data-infra Component: provider, datagen, fallback, adapters

Comments

@hsivonen
Copy link
Member

Ensure that the provider is performs these alias mappings from CLDR for collations (Traditional Chinese and Norwegian have more specific issues):

pa_IN: pa_Guru_IN
sr_RS: sr_Cyrl_RS
ars: ar_SA
in_ID: id_ID
iw: he
in: id
mo: ro
sh_YU: sr_Latn_RS
sh: sr_Latn
sr_ME: sr_Cyrl_ME
sh_BA: sr_Latn_BA
sh_CS: sr_Latn_RS
sr_BA: sr_Cyrl_BA
iw_IL: he_IL

@hsivonen hsivonen added the C-data-infra Component: provider, datagen, fallback, adapters label May 30, 2022
@hsivonen hsivonen added this to the ICU4X 1.0 (Features) milestone May 30, 2022
@hsivonen
Copy link
Member Author

CC @sffc.

Norwegian: #1963.
Traditional Chinese: #1964.

@hsivonen
Copy link
Member Author

Looks like these aliases exist as JSON.

@sffc
Copy link
Member

sffc commented Jun 16, 2022

We'll do mappings according to likely subtags and parent locales by default:

My proposed policy for legacy subtags (aliases) is that developers should call LocaleCanonicalizer::canonicalize before passing the locale into ICU4X.

@sffc
Copy link
Member

sffc commented Sep 16, 2022

The source for these mappings is:

https://github.com/unicode-org/icu/blob/main/tools/cldr/cldr-to-icu/build-icu-data.xml#L263

#2506 lays the groundwork for this to work. I will add tests for this iteratively.

@sffc
Copy link
Member

sffc commented Sep 26, 2022

I'm using this as the main tracking issue for collation fallbacks.

@sffc sffc modified the milestones: ICU4X 1.0 (Final), ICU4X 1.1 Sep 26, 2022
@sffc sffc modified the milestones: ICU4X 1.1, ICU4X 1.x Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-data-infra Component: provider, datagen, fallback, adapters
Projects
None yet
Development

No branches or pull requests

2 participants