Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement numbering system selection #510

Closed
sffc opened this issue Feb 26, 2021 · 3 comments · Fixed by #2246
Closed

Implement numbering system selection #510

sffc opened this issue Feb 26, 2021 · 3 comments · Fixed by #2246
Assignees
@sffc
Labels
A-tailoring Area: User preferences, locale extensions, tailoring C-numbers Component: Numbers, units, currencies S-medium Size: Less than a week (larger bug fix or enhancement) T-core Type: Required functionality
Milestone
ICU4X 1.0 (Features)

Comments

@sffc
Copy link
Member

sffc commented Feb 26, 2021

In #467, for expediency, I'm delivering the locale's default numbering system at all times, rather than looking at the -u-nu- Unicode extension. This issue is to track a follow-up where we obey the Unicode extension.
@sffc sffc added C-numbers Component: Numbers, units, currencies A-tailoring Area: User preferences, locale extensions, tailoring T-core Type: Required functionality labels Feb 27, 2021
@sffc sffc added this to the 2021-Q2-m1 milestone Mar 4, 2021
@sffc sffc self-assigned this Mar 4, 2021
@sffc sffc added the S-medium Size: Less than a week (larger bug fix or enhancement) label Apr 3, 2021
@sffc sffc modified the milestones: 2021-Q2-m1, ICU4X 0.4 Apr 19, 2021
@sffc
Copy link
Member Author

sffc commented Apr 19, 2021

Relates to #419

@sffc sffc added the blocked A dependency must be resolved before this is actionable label Apr 19, 2021
@sffc sffc mentioned this issue Apr 19, 2021
Open
@sffc sffc modified the milestones: ICU4X 0.4, ICU4X 0.5 Aug 11, 2021
@sffc sffc removed their assignment Aug 11, 2021
@sffc sffc added the help wanted Issue needs an assignee label Aug 11, 2021
@sffc
Copy link
Member Author

sffc commented Jan 27, 2022

Relates to #1203

@sffc sffc modified the milestones: ICU4X 0.5, 2022 Q1 0.6 Sprint B Jan 27, 2022
@sffc sffc self-assigned this Jan 27, 2022
@sffc sffc removed help wanted Issue needs an assignee blocked A dependency must be resolved before this is actionable labels Jan 27, 2022
@zbraniecki
Copy link
Member

It would be nice to have a generic single logic for taking OptionsBag and LocaleExtensions and producing OptionsBag. This operation should be executed for all constructors that accept Locale and OptionsBag.

@sffc sffc modified the milestones: 2022 Q1 0.6 Sprint B, ICU4X 1.0 Mar 21, 2022
This was referenced Jul 24, 2022
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sffc sffc

Labels
A-tailoring Area: User preferences, locale extensions, tailoring C-numbers Component: Numbers, units, currencies S-medium Size: Less than a week (larger bug fix or enhancement) T-core Type: Required functionality
Projects
None yet
Milestone
ICU4X 1.0 (Features)
Development

Successfully merging a pull request may close this issue.

Add numbering system support sffc/omnicu
2 participants
@zbraniecki @sffc