Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In skeleton matching, combine date and time patterns #585

Closed
gregtatum opened this issue Mar 29, 2021 · 1 comment · Fixed by #617
Closed

In skeleton matching, combine date and time patterns #585

gregtatum opened this issue Mar 29, 2021 · 1 comment · Fixed by #617
Assignees
Labels
C-datetime Component: datetime, calendars, time zones S-medium Size: Less than a week (larger bug fix or enhancement)

Comments

@gregtatum
Copy link
Member

https://unicode.org/reports/tr35/tr35-dates.html#Matching_Skeletons

  1. Divide the request into a date fields part and a time fields part.
  2. For each part, find the matching dateFormatItem, and expand the pattern as above.
  3. Combine the patterns for the two dateFormatItems using the appropriate dateTimeFormat pattern, determined as follows from the requested date fields:
  • If the requested date fields include wide month (MMMM, LLLL) and weekday name of any length (e.g. E, EEEE, c, cccc), use
  • Otherwise, if the requested date fields include wide month, use
  • Otherwise, if the requested date fields include abbreviated month (MMM, LLL), use
  • Otherwise use

This is a follow-up to #481. It blocks #272.

@gregtatum gregtatum added the C-datetime Component: datetime, calendars, time zones label Mar 29, 2021
@gregtatum gregtatum self-assigned this Mar 29, 2021
@gregtatum
Copy link
Member Author

2020-04-02: This needs to be implemented.

My current status on this is that I have a working copy of this locally.

@gregtatum gregtatum added the S-medium Size: Less than a week (larger bug fix or enhancement) label Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-datetime Component: datetime, calendars, time zones S-medium Size: Less than a week (larger bug fix or enhancement)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant