We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Any typescript environment.
Use typescript types.
The return type for parseTar() and parseTarGzip() should be ParsedTarFileItem[] instead of just TarFileItem[].
parseTar()
parseTarGzip()
ParsedTarFileItem[]
TarFileItem[]
In src/parse.ts:
src/parse.ts
export function parseTar(data: ArrayBuffer | Uint8Array): TarFileItem[] { const buffer = (data as Uint8Array).buffer || data; const files: ParsedTarFileItem[] = []; // ... return files; }
It's clear that the returned type should be ParsedTarFileItem[].
I made a simple PR resolving this issue.
No response
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
Environment
Any typescript environment.
Reproduction
Use typescript types.
Describe the bug
The return type for
parseTar()
andparseTarGzip()
should beParsedTarFileItem[]
instead of justTarFileItem[]
.Additional context
In
src/parse.ts
:It's clear that the returned type should be
ParsedTarFileItem[]
.I made a simple PR resolving this issue.
Logs
No response
The text was updated successfully, but these errors were encountered: